Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): center align inner text/icon #3787

Merged
merged 3 commits into from
May 8, 2024

Conversation

ShrinidhiUpadhyaya
Copy link
Contributor

Description

The icon inside the toggle is not vertically centered.

Current behavior

image

New behavior

image

Additional Information

If the PR gets accepted please use my GitHub email-id (shrinidhiupadhyaya1195@gmail.com) instead of my other email-id for the Co-authored-by: message.

Copy link

codesandbox bot commented May 5, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented May 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 0:50am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 0:50am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:50am

Copy link

vercel bot commented May 5, 2024

Someone is attempting to deploy a commit to the rsuite Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codesandbox-ci bot commented May 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.85%. Comparing base (10415d4) to head (a35a6cc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3787   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files         659      659           
  Lines       22793    22793           
  Branches     3091     3091           
=======================================
  Hits        21393    21393           
  Misses        710      710           
  Partials      690      690           
Flag Coverage Δ
ChromeCi 93.81% <ø> (ø)
Firefox 93.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo merged commit c2a8fb1 into rsuite:main May 8, 2024
16 checks passed
@ShrinidhiUpadhyaya ShrinidhiUpadhyaya deleted the fix/toggle branch May 9, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants