New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: Drop support for OpenAPI v2 #574
Conversation
6d7b3f0
to
61ecf12
Compare
e0a416c
to
54ca72c
Compare
f4cdcba
to
ba1f6c6
Compare
277f06b
to
ceca547
Compare
8dc7528
to
389382c
Compare
7c9983b
to
43a4db2
Compare
This is a long running branch with a lot of changes... where are we at on this one? I'm guessing we'll have to do another pass since there are changes in master that appear to be removed here. |
43a4db2
to
3d3b29c
Compare
@mattpolito, besides responding to the review suggestions (renaming However, together with this, in 3.0.0 we also need to take care of updating other deprecations (Ruby, Rspec). It would be better to have the other changes ready as well (see #625, #636), when we decide to merge this one. I'm keeping the PR updated with latest merges in the meantime. |
9fb361b
to
7b3ffe2
Compare
@mattpolito @jtannas, I consider this change ready. I'm wondering about what should we put into the migration document. The summary of this PR would probably be
Other changes (e.g. moving Not sure we need to document that part here too 🤔. |
Awesome I'll take a look this weekend to get a another comb through of it. If we're changing everything from swagger to openapi, I'd recommend us changing the task to something different as well and aliasing swaggerize to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we considered the upgrade path for these changes? Dropping support for OpenAPI v2 is completely different than renaming so many things. For example has there been deprecation warnings put in place to say that swagger_root
& swagger_endpoint
are going away? That's going to break every install.
I know a lot of work has been put into this but the support for v2 should be dropped without renaming public api methods.
Then deprecation warnings put in saying that those methods will be changed in the next release.
If it comes along with a major version bump we could maybe throw caution to the wind but might be a bit bad form.
ee8f670
to
edac41e
Compare
@mattpolito These changes would come along with a major version, but I agree. We can do better with letting folks know that we're renaming the methods in v3. The PR is now aiming to be merged into v3 branch and I'll create a PR into current master, to warn about the change. |
edac41e
to
1836651
Compare
@mattpolito, since these changes are going into The PR adding warning about upcoming changes in |
Problem
As mentioned in #503, maintaining OpenAPI v2 specification is becoming too big overhead to support.
Fixes #609
Solution
This PR is intended to drop all code related to OpenAPI v2 and end its support.
Also, because the Swagger has been renamed to OpenAPI, the codebase and documentation is also being updated in order to avoid confusion in terminology.
This concerns this parts of the OpenAPI Specification:
The changes I made are compatible with:
Related Issues
Checklist
Steps to Test or Reproduce