Add warning about methods renaming #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanblanco
force-pushed
the
rebranding_warning
branch
from
dda25bb
to
3ffb7ba
Compare
6 tasks
mattpolito
approved these changes
Nov 13, 2023
|
Could you add aliases for the new methods in a 2.x version? Now we cannot silence these warnings 🤷🏻 |
|
That change is somewhat not usable with configurations where rspec doesnt allow any warnings. Had to downgrade for a while. |
|
Sorry about this. The issue #703 addresses the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning about renaming methods in next major release
The changes I made are compatible with:
Related Issues
#574 (review)
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.