Refactor variable and enum declarations to be statements. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now variables can be declared within functions anywhere, not just at the beginning, and enums can go into functions too.
This could also easily work to support default parameter values, simply by allowing ctx==Par and not only ctx==Loc in the condition. Not sure how I feel about that, considering it's C and not C++...
jserv
reviewed
Aug 18, 2018
| else if (tk == Char) { next(); ty = CHAR; } | ||
| while (tk == Mul) { next(); ty = ty + PTR; } | ||
| if (tk != Id) { printf("%d: bad parameter declaration\n", line); return -1; } | ||
| if (id[Class] == Loc) { printf("%d: duplicate parameter definition\n", line); return -1; } |
There was a problem hiding this comment.
What is the impact after the removal of Line 412?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now variables can be declared within functions anywhere, not just
at the beginning, and enums can go into functions too.
The three similar declaration-parsing blocks are unified into one. The
end result is thereby negative code growth (-17 lines).