Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #72 the lvalue checking was too loose #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tommythorn
Copy link

No description provided.

Extends c4 by adding Abstract Syntax Tree creation and back-end code
generation
@tommythorn tommythorn changed the title The the lvalue checking #72 Fix the lvalue checking #72 Sep 10, 2022
@tommythorn tommythorn changed the title Fix the lvalue checking #72 Fix #72 the lvalue checking was too loose Sep 10, 2022
The usual problem with the assumption that int == intptr_t.  The
proper fix is a bit intrusive so we use the simpler but very hackish
macro trick.

Lacked header inclusions for mmap, dsym, and qsort but these aren't
needed for self-hosting.
@andrakis
Copy link

As it is, I doubt this will get merged. There's some nice stuff in this, like more C constructs and a fix for potentially adding LI where it shouldn't be. But I think there's far too many changes, and it's starting to get away from the core idea of the simple self hosting compiler.

I'll be adding things like your LI fix, do-while and for loops to my personal fork, but there's just too much in this PR and I have doubts it would be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants