Updates to support Chrome 53 requirements #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Chrome 53, support for the standardised form of media constraints was implemented.
Unlike Firefox's implementation, Chrome 53+ enforces a strict policy of not allowing mixed constraint formats - the standard format does away with the mandatory/optional attributes completely, resulting in the half/half approach of
rtc-captureconfigto fail.This moves the entirety of the
buildConstraintsimplementation to the constraint implementations, allowing a much greater degree of control over how the individual implementations should handle the building of an appropriate media constraint object for the browser that is requesting the constraints.It also updates the standard constraint implementation to be compatible with Chrome 53+, as well as the previously supported versions of Firefox.
Chrome 52 and below continue to be supported with the legacy implementation.