changed <strong> from html to css #2699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@agjohnson i just learned html /css last night so tell if i can make some corrections.
|
@ericholscher is this alright or some thing else needs to be done. |
|
@ericholscher Isn't this what you wanted me to do with the files from #2503 (review). |
|
Ping @ericholscher . |
agjohnson
requested changes
Mar 21, 2017
| <th><p class ="strong">Day (UTC)</p></th> | ||
| <th><p class ="strong">Views</p></th> | ||
| <th><p class ="strong">Clicks</p></th> | ||
| <th><p class ="strong">CTR</p></th> |
There was a problem hiding this comment.
My feedback to the original approach was that this didn't need to use <strong> tags on each cell. Instead of applying <strong> or <p class="strong"> to each <th>, we should instead be applying a heavier weight to the table tr th css selector.
| p.strong { | ||
| font-weight: bold; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
We don't use inline styles, you'll find our css at media/css/core.css
agjohnson
added
PR: work in progress
agjohnson
added
PR: work in progress
|
@Riyuzakii Thanks for the work, but this has been open a bit long! You're welcome to keep contributing in the future. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@agjohnson i just learned html /css last night so tell if i can make some corrections.