Replaced usage of deprecated function get_fields_with_model with new … #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…local function, which does the same thing.
agjohnson
reviewed
Aug 17, 2017
readthedocs/builds/version_slug.py
Outdated
| @@ -28,6 +28,15 @@ | |||
| from builtins import range | |||
|
|
|||
|
|
|||
| def get_fields_with_model(cls): | |||
| return [ | |||
There was a problem hiding this comment.
If this is a prescribed Django fix for this, perhaps link to the permalink in docs here to explain what this is for.
humitos
approved these changes
Nov 23, 2017
|
I don't think so. @agjohnson review again? |
|
Thanks for the @josejrobles, looks good to me! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced usage of deprecated function get_fields_with_model with new local function, which does the same thing.