Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected the support for selecting from multiple python interpreters #330

Merged
merged 3 commits into from
Mar 1, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions readthedocs/projects/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,10 @@ class ImportProjectForm(ProjectForm):
repo = forms.CharField(required=True,
help_text=_(u'URL for your code (hg or git). Ex. http://github.com/ericholscher/django-kong.git'))

"""
python_interpreter = forms.ChoiceField(
choices=constants.PYTHON_CHOICES, initial='python',
help_text=_("(Beta) The Python interpreter used to create the virtual environment."))
"""


class Meta:
model = Project
fields = (
Expand Down
2 changes: 1 addition & 1 deletion readthedocs/projects/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def update_imported_docs(version_pk):
# Here the command has been modified to support different
# interpreters.
update_docs_output['venv'] = run('{cmd} --distribute {site_packages} {path}'.format(
cmd='{interpreter} -m virtualenv'.format(
cmd='virtualenv -p {interpreter}'.format(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this little change remove the need of the virtualenv module installed on different interpreters in the same host.

interpreter=project.python_interpreter),
site_packages=site_packages,
path=project.venv_path(version=version_slug)))
Expand Down