Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Simple task to finish inactive builds #3312
This is an initial idea to solve these kind of issues and avoid user confusions:
Here is an example on how this will look like
Ah yes, this could be updated in our docs probably.
We run celery beat just as we run celery:
So this would be another command to run for local development. You want to run on a separate worker, as it should only have 1 concurrent process. That is, this will result in multiple scheduled tasks, as there is 4 concurrency:
I'm fine not supporting this when running celery as
Custom time limit should be 150-200% of the project build time. The project build time is the
Also, thinking more on this, it might be helpful to include more information in the error message. Adding something similar to our general error reporting would help -- "If you continue to encounter this error, file a support request with and reference this build id (#)"
I think this is in the right direction. I added some feedback on the questions you've had so far, so we'll probably need another review when those changes are added.
I just update this PR with:
Let me know if this is OK for you and also how to configure this as an scheduled task since I don't find the CELERY BEAT setting.
So this method is close. Perhaps my suggestion is the best compromise between complexity and the most correct UX.
I think we'll want at least 3 test cases out of this:
- Legitimate build isn't marked finished early
- Build is custom time limit isn't marked finished early
- Build without custom time limit is marked finished
I added a test case for this escenario. I thought it was better to have 3 builds at the same time instead of one build per test. Let me know if you agree with me or want me to split them.
I think it's easier to understand and also it's more close to the reality.
Dec 14, 2017
The only thing missing is setup the celery beat to effectively run this task El 14 dic. 2017 3:59 p. m., "Anthony" <email@example.com> escribió:…
Merged #3312 <#3312>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#3312 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAO7sF-eg9wRiH5T-5CALAU1bL2qOBC_ks5tAYwkgaJpZM4QpOay> .