Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Show proper error to user when conf.py is not found #3326
I added a couple of tests for old behaviour and also to catch this PR behaviour. Besides, I added the exception message as a class attribute.
Please, re-review this PR when you have some time.
(the last commit is styling, so you can skip it from the logic review)
Link for logic commits: https://github.com/rtfd/readthedocs.org/pull/3326/files/f44ba0eb3714c7e607925c75d1eec9c65fbe4a35
I noted a copy change, but this looks good otherwise. Let's keep thinking about how to best surface build suggestions, as I think this is a good pattern so far. I'll open a separate ticket to start discussing how to better implement the build changes, as I think too much logic is being hidden in templates currently.
This PR should be ready to merge.
The linting error is unrelated.
I didn't find why it's failing yet.