Don't claim the outcome of an unfinished build is 'failed' #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the 'build-state' span before the 'build-success' one to make it more obvious that the build is still running. It also changes the text of the 'build-success' span to 'Not yet finished' if the build state is not 'finished'.
|
Yay. I have been a bad maintainer and been meaning to fix this for a while. Thanks! |
ericholscher
added a commit
that referenced
this pull request
Mar 18, 2013
Don't claim the outcome of an unfinished build is 'failed'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the 'build-state' span before the 'build-success' one to make
it more obvious that the build is still running. It also changes the
text of the 'build-success' span to 'Not yet finished' if the build
state is not 'finished'.