New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log in the proper place and add the image name used #3750

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@humitos
Member

humitos commented Mar 7, 2018

Now that we are changing/upgrading Docker images, this will help us to know which image we are using to build the documentation.

Also, I'm logging in the proper place create_container method instead of in the __enter__ that could not create the container if it's already created.

@humitos humitos requested a review from agjohnson Mar 7, 2018

@agjohnson

LGTM

@agjohnson agjohnson merged commit 2a7a113 into master Mar 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the humitos/container/log branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment