Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync valid webhook for project manually imported #3935

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 10, 2018

When a project is imported manually, if the user has a valid social account we setup a webhook for this project.

If the user goes to Integrations and try to resync, we handle that properly (use the Project.remote_repository only when available, otherwise use the accounts registered for that service even if they are not associated with that project)

Closes https://github.com/readthedocs/readthedocs-corporate/issues/297

When a project is imported manually, if the user has a valid social
account we setup a webhook for this project.

If the user goes to Integrations and try to resync, we handle that
properly (use the Project.remote_repository only when available,
otherwise use the accounts registered for that service even if they
are not associated with that project)
@humitos humitos requested a review from agjohnson April 10, 2018 22:52
@humitos humitos requested review from a team and removed request for agjohnson April 10, 2018 22:52
@agjohnson agjohnson added this to the 2.4 milestone Apr 11, 2018
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly on the fence about trying to do this magically on import and on resync, but for now this seems to address the issue, so 👍

We can always readdress this and pull this functionality out from both areas. This at least matches our import more.

@agjohnson agjohnson merged commit 0c9fafb into master Apr 13, 2018
@agjohnson agjohnson deleted the humitos/webhook/resync-when-manually-imported branch April 13, 2018 21:49
xrmx pushed a commit to italia/docs.italia.it that referenced this pull request Apr 17, 2018
When a project is imported manually, if the user has a valid social
account we setup a webhook for this project.

If the user goes to Integrations and try to resync, we handle that
properly (use the Project.remote_repository only when available,
otherwise use the accounts registered for that service even if they
are not associated with that project)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants