New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync valid webhook for project manually imported #3935

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
2 participants
@humitos
Member

humitos commented Apr 10, 2018

When a project is imported manually, if the user has a valid social account we setup a webhook for this project.

If the user goes to Integrations and try to resync, we handle that properly (use the Project.remote_repository only when available, otherwise use the accounts registered for that service even if they are not associated with that project)

Closes rtfd/readthedocs-corporate#297

Resync valid webhook for project manually imported
When a project is imported manually, if the user has a valid social
account we setup a webhook for this project.

If the user goes to Integrations and try to resync, we handle that
properly (use the Project.remote_repository only when available,
otherwise use the accounts registered for that service even if they
are not associated with that project)

@humitos humitos requested a review from agjohnson Apr 10, 2018

@humitos humitos requested review from rtfd/core and removed request for agjohnson Apr 10, 2018

@agjohnson agjohnson added this to the 2.4 milestone Apr 11, 2018

@agjohnson

I'm mostly on the fence about trying to do this magically on import and on resync, but for now this seems to address the issue, so 👍

We can always readdress this and pull this functionality out from both areas. This at least matches our import more.

@agjohnson agjohnson merged commit 0c9fafb into master Apr 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the humitos/webhook/resync-when-manually-imported branch Apr 13, 2018

xrmx added a commit to italia/docs.italia.it that referenced this pull request Apr 17, 2018

Resync valid webhook for project manually imported (rtfd#3935)
When a project is imported manually, if the user has a valid social
account we setup a webhook for this project.

If the user goes to Integrations and try to resync, we handle that
properly (use the Project.remote_repository only when available,
otherwise use the accounts registered for that service even if they
are not associated with that project)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment