tests: fixup url tests in test_privacy_urls #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased to have green tests and hopefully a review :) |
|
Ping, this is fixing flaky tests :) |
|
Ping :) |
We have two issues. First we were checking always against the default status_code and not the one we expected, second we can't assume that integration id is always 1 but update urls with the current id. Fix readthedocs#3957
|
Looks good, thanks! Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.
Fix #3957