New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fixup url tests in test_privacy_urls #3966

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
4 participants
@xrmx
Contributor

xrmx commented Apr 18, 2018

We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix #3957

@agjohnson agjohnson added this to the Cleanup milestone Apr 19, 2018

@xrmx

This comment has been minimized.

Contributor

xrmx commented Apr 24, 2018

Rebased to have green tests and hopefully a review :)

@xrmx

This comment has been minimized.

Contributor

xrmx commented Apr 29, 2018

Ping, this is fixing flaky tests :)

@xrmx

This comment has been minimized.

Contributor

xrmx commented May 24, 2018

Ping :)

@xrmx xrmx closed this May 29, 2018

@xrmx xrmx deleted the italia:fixuppgtests branch May 29, 2018

@xrmx xrmx restored the italia:fixuppgtests branch May 29, 2018

@xrmx xrmx reopened this May 29, 2018

tests: fixup url tests in test_privacy_urls
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix #3957
@ericholscher

This comment has been minimized.

Member

ericholscher commented Jun 5, 2018

Looks good, thanks! Sorry for the delay.

@ericholscher ericholscher merged commit e393011 into rtfd:master Jun 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment