Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config module from rtd-build repo #4242

Merged
merged 7 commits into from
Jun 19, 2018

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 14, 2018

Still WIP

@stsewd stsewd added the PR: work in progress Pull request is not ready for full review label Jun 14, 2018
@stsewd
Copy link
Member Author

stsewd commented Jun 14, 2018

Dependencies problem with pytest-describe==0.11.0 😞

pytest-describe is incompatible with the current pytest (3.6.1)
had to downgrade to 3.2.5
pytest<4,>=3.3.2
# 3.6.1 and >3.2.5 is incompatible
# with pytest-describe 0.11.0
pytest==3.2.5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest-describe is incompatible with the current pytest (3.6.1) had to downgrade to 3.2.5 😧. We can port those tests later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make an issue to address this later in the project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an issue here #4270

@stsewd
Copy link
Member Author

stsewd commented Jun 14, 2018

Not sure if this PR is big enough, but is ready. I think moving config.py is going to change a lot of files (here we need to change the imports of the existing files in rtd).

@stsewd stsewd requested a review from agjohnson June 14, 2018 20:31
@stsewd stsewd removed the PR: work in progress Pull request is not ready for full review label Jun 14, 2018
@agjohnson agjohnson added the PR: work in progress Pull request is not ready for full review label Jun 15, 2018
@agjohnson agjohnson added this to the YAML File Completion milestone Jun 15, 2018
@stsewd stsewd mentioned this pull request Jun 19, 2018
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I checked this out locally to test the diffs on these files. Looks like minimal changes.

I think you're right that the last piece will be the most changes, when porting over config.py. If you're going to address in a separate PR, we can merge this now.

pytest<4,>=3.3.2
# 3.6.1 and >3.2.5 is incompatible
# with pytest-describe 0.11.0
pytest==3.2.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make an issue to address this later in the project.

@agjohnson agjohnson merged commit db8f092 into readthedocs:master Jun 19, 2018
@stsewd stsewd deleted the move-back-config-repo-2nd-step branch June 19, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: work in progress Pull request is not ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants