Improvements for the build/version admin #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Jul 10, 2018
humitos
approved these changes
Jul 10, 2018
| @@ -13,14 +13,22 @@ class BuildCommandResultInline(admin.TabularInline): | |||
|
|
|||
| class BuildAdmin(admin.ModelAdmin): | |||
| fields = ('project', 'version', 'type', 'state', 'error', 'success', 'length', 'cold_storage') | |||
| list_display = ('project', 'success', 'type', 'state', 'date') | |||
| list_display = ('id', 'project', 'version_name', 'success', 'type', 'state', 'date') | |||
There was a problem hiding this comment.
nit: I think the id could be removed from this list since I suppose it's not very useful.
There was a problem hiding this comment.
Oh! If we remove the id the link would be the project and it will be confusing. So, I suppose that was what you wanted. In that case, I'm 👍 on leaving it.
I'm sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #4001, I noted the pain of using the Django admin to look at builds and versions. These improvements are small improvements to make the admin usable.
Build admin screen