New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sponsors list to footer #4424

Merged
merged 3 commits into from Aug 15, 2018

Conversation

Projects
None yet
4 participants
@davidfischer
Contributor

davidfischer commented Jul 24, 2018

Edits: 2018-08-01

This PR got expanded (scope creeped) and now adds a number of sponsors to the footer.

Brand guidelines & assets

In general, I followed the following the below guidelines except I did desaturate any color if no black and white logo was provided.

Screenshot

screen shot 2018-08-01 at 10 30 52 am

@davidfischer davidfischer requested a review from rtfd/core Jul 24, 2018

@RichardLitt

This comment has been minimized.

Show comment
Hide comment
@RichardLitt

RichardLitt Jul 25, 2018

Member

Looks good to me.

Member

RichardLitt commented Jul 25, 2018

Looks good to me.

@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher

ericholscher Aug 1, 2018

Member

This looks good. I think it might be more useful to specify a bit more about what they are providing us. I really like what https://pypi.org/ does here:

screenshot 2018-08-01 09 21 11

So we could do something like:

Cloudflare
DNS & SSL certificates

Member

ericholscher commented Aug 1, 2018

This looks good. I think it might be more useful to specify a bit more about what they are providing us. I really like what https://pypi.org/ does here:

screenshot 2018-08-01 09 21 11

So we could do something like:

Cloudflare
DNS & SSL certificates

@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos

humitos Aug 1, 2018

Member

I like Eric's proposal.

We may want to include together with Cloudflare other services that we use (although, I'm not sure what's the contract we have with them: Azure, Sentry, New Relic, and maybe others that I'm missing here)

Member

humitos commented Aug 1, 2018

I like Eric's proposal.

We may want to include together with Cloudflare other services that we use (although, I'm not sure what's the contract we have with them: Azure, Sentry, New Relic, and maybe others that I'm missing here)

@davidfischer

This comment has been minimized.

Show comment
Hide comment
@davidfischer

davidfischer Aug 1, 2018

Contributor

I think it might be more useful to specify a bit more about what they are providing us

My plan was to link to the upcoming blog post on the subject but I think I like your proposal better.

Contributor

davidfischer commented Aug 1, 2018

I think it might be more useful to specify a bit more about what they are providing us

My plan was to link to the upcoming blog post on the subject but I think I like your proposal better.

@davidfischer davidfischer changed the title from Add Cloudflare to the sponsors list and footer to Add Sponsors list to footer Aug 1, 2018

@davidfischer

This comment has been minimized.

Show comment
Hide comment
@davidfischer

davidfischer Aug 1, 2018

Contributor

I have updated this PR and edited the description. This PR was changed to add a number of sponsors to the footer.

Contributor

davidfischer commented Aug 1, 2018

I have updated this PR and edited the description. This PR was changed to add a number of sponsors to the footer.

@humitos

humitos approved these changes Aug 1, 2018

😍

@davidfischer

This comment has been minimized.

Show comment
Hide comment
@davidfischer

davidfischer Aug 1, 2018

Contributor

I'll wait on merging this until we are a little closer to the Azure switchover date.

Contributor

davidfischer commented Aug 1, 2018

I'll wait on merging this until we are a little closer to the Azure switchover date.

@ericholscher

Looks good. 👍

@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos

humitos Aug 15, 2018

Member

I suppose we can merge this PR.

Member

humitos commented Aug 15, 2018

I suppose we can merge this PR.

@davidfischer davidfischer merged commit 79032b5 into master Aug 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidfischer davidfischer deleted the davidfischer/cloudflare-sponsor-logo branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment