Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Force resolver to use PUBLIC_DOMAIN over HTTPS if not Domain.https #4579
I found this while running tests on Corporate site since we don't serve documentation over plain HTTP there. So, we need a way to force the https protocol even when the project has a Domain object (but https=False). In this case, we force to use our PUBLIC_DOMAIN URL over HTTPS.
There shouldn't be changes in the logic. This PR only makes the resolver extensible from corporate site.
After the changes in .org's resolver that David did around HTTPS some corporate tests start failing and when trying to fix them I realize that it was not possible with the current implementation of the resolver under .org.
So, I refactored it to be able to extend it from corporate.