Do not re-raise the exception if the one that we are checking #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Oct 16, 2018
readthedocs/core/utils/__init__.py
Outdated
| @@ -222,6 +222,7 @@ def safe_makedirs(directory_name): | |||
| try: | |||
| os.makedirs(directory_name) | |||
| except OSError as e: | |||
| if e.errno == errno.EEXIST: | |||
| if e.errno == errno.EEXIST: # 17, FileExistsError | |||
There was a problem hiding this comment.
Can we rewrite this as raise if not e.errno == errno.EEXIST?
There was a problem hiding this comment.
I think we can't. Doesn't look like valid syntax to me.
>>> raise if None is []
File "<stdin>", line 1
raise if None is []
^
SyntaxError: invalid syntax
>>>
>>> raise if None is [] else 2
File "<stdin>", line 1
raise if None is [] else 2
^
SyntaxError: invalid syntax
There was a problem hiding this comment.
OK. We should at least be able to do:
if not e.errno == errno.EEXIST:
raise
There was a problem hiding this comment.
oh, maybe we can write it like
if e.errno != errno.EEXIST:
raise
is that what you ment?
humitos
force-pushed
the
humitos/safemakedirs/exception
branch
from
81c7d44
to
812b666
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this commit introduced the problem: 0432ee8 (this is the PR: #2765)
The problem is that it's always re-raising the exception, even if the problem is the one that we checking in the
if. I think this has generated 4.2k Sentry logs: https://sentry.io/read-the-docs/readthedocs-org/issues/628363742/?query=is:unresolved