Fix migration name on modified date migration #4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
approved these changes
Nov 5, 2018
stsewd
reviewed
Nov 5, 2018
| @@ -8,7 +8,7 @@ | |||
| class Migration(migrations.Migration): | |||
|
|
|||
| dependencies = [ | |||
| ('projects', '0029_add_additional_languages'), | |||
| ('projects', '0030_add_modified_date_importedfile'), | |||
There was a problem hiding this comment.
Ups, I approved, but this should be 0030_change-max-length-project
There was a problem hiding this comment.
Good thing CI caught it :D
Codecov Report
@@ Coverage Diff @@
## master #4867 +/- ##
=======================================
Coverage 36.31% 36.31%
=======================================
Files 158 158
Lines 9993 9993
Branches 1262 1262
=======================================
Hits 3629 3629
Misses 6350 6350
Partials 14 14 |
stsewd
reviewed
Nov 5, 2018
| @@ -8,7 +8,7 @@ | |||
| class Migration(migrations.Migration): | |||
|
|
|||
| dependencies = [ | |||
| ('projects', '0029_add_additional_languages'), | |||
| ('projects', '0030_change-max-length-project'), | |||
There was a problem hiding this comment.
Sorry, I just copied the filename from github and it got truncated, the complete filename is 0030_change-max-length-project-slug
There was a problem hiding this comment.
There was a problem hiding this comment.
quietly rewrites history like it never happened
ericholscher
force-pushed
the
fix-migration
branch
from
1ab5146
to
8430b6b
Compare
stsewd
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.