Moved project tasks #4888
Moved project tasks #4888
Conversation
Alig1493
force-pushed
the
refactor_tasks
branch
from
f7bb4cb
to
6c7cf45
Compare
Codecov Report
@@ Coverage Diff @@
## master #4888 +/- ##
==========================================
+ Coverage 76.75% 76.79% +0.04%
==========================================
Files 158 160 +2
Lines 10048 10073 +25
Branches 1265 1265
==========================================
+ Hits 7712 7736 +24
- Misses 1995 1996 +1
Partials 341 341
|
| msg='Creating ImportedFiles', | ||
| ) | ||
| ) | ||
| from readthedocs.projects.tasks import _manage_imported_files |
There was a problem hiding this comment.
Looks like this isn't used on the projects.tasks module, so it can be moved too
readthedocs/builds/tasks.py
Outdated
| ) | ||
|
|
||
|
|
||
| # Random Tasks |
There was a problem hiding this comment.
we can remove this comment now I guess
| try: | ||
| requests.post(hook_url, data=data) | ||
| except Exception: | ||
| log.exception('Failed to POST on webhook url: url=%s', hook_url) |
There was a problem hiding this comment.
Despite the naming, none of these are part of the readthedocs.notification subsystem. These are still probably better off in a project.tasks.notifications or something unrelated to our notification system.
Eventually a refactor might combine these two concepts, but they are separate until then.
agjohnson
added
the
PR: work in progress
Alig1493
force-pushed
the
refactor_tasks
branch
from
6c7cf45
to
ceb0579
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Moved project tasks to places where they might be more appropriate.
Close #3775