Remove deprecated "models.permalink" #4975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4975 +/- ##
======================================
Coverage 76.8% 76.8%
======================================
Files 158 158
Lines 9937 9937
Branches 1241 1241
======================================
Hits 7632 7632
Misses 1973 1973
Partials 332 332
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4975 +/- ##
======================================
Coverage 76.8% 76.8%
======================================
Files 158 158
Lines 9937 9937
Branches 1241 1241
======================================
Hits 7632 7632
Misses 1973 1973
Partials 332 332
|
stsewd
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django.db.models.permalink() is deprecated 4-5 years ago (ticket #18974) and it is now completely removed in Django 2.1 (Deprecation Timeline for Django 2.1)