Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep command output when it's killed #5015

Merged
merged 2 commits into from Dec 21, 2018

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 19, 2018

Closes #4957

Before

screenshot_2018-12-18 read the docs read the docs

After

screenshot_2018-12-18 read the docs read the docs 2

Need to point out that it took me some attempts to trigger the memory issue, so, in the last picture I wasn't able to capture the full output, but in some previous tests the output was bigger

screenshot_2018-12-18 read the docs read the docs 1

@stsewd stsewd requested a review from a team December 19, 2018 00:36
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. 👍

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this working!

readthedocs/doc_builder/environments.py Outdated Show resolved Hide resolved
@stsewd stsewd merged commit 62e2d98 into readthedocs:master Dec 21, 2018
@stsewd stsewd deleted the keep-cmd-output-when-killed branch December 21, 2018 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants