Be more defensive in our 404 handler #5243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
approved these changes
Feb 6, 2019
davidfischer
reviewed
Feb 6, 2019
| version = project.versions.get(slug=version_slug) | ||
| version_qs = project.versions.filter(slug=version_slug) | ||
| if version_qs.exists(): | ||
| version = version_qs.first() |
There was a problem hiding this comment.
This block could just be:
version = project.versions.filter(slug=version_slug).first()
There was a problem hiding this comment.
Returns the first object matched by the queryset, or None if there is no matching object.
https://docs.djangoproject.com/en/1.11/ref/models/querysets/#first
|
Merging this because I already hotfixed it, will update in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.