-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pip installs #5386
Fix pip installs #5386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense for me, not sure if there was a reason for this in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Seems a safer and robust way to handle this.
This commit broke my build hard. I'm relying on some dependencies for my build that are only available via conda. The
Any workarounds or other hints would be very welcome! Example failure: https://readthedocs.org/projects/ipyscales/builds/8821876/ |
Xref after diggin through blame history: 433f198 |
hmm, what about just removing the flag? What would be the default behaviour of pip? Is this only happening with conda? |
I'm guessing the reason the The only place the |
Thanks @orlnub123 for your explanation and help here! I suggest you to open a new issue because I feel that this conversation will be lost here in a merged pull request. I supposed that the change to At this point, I'm not sure if we can have a "general pip command that works for all the cases" :( |
Thanks for the context! Using it, I've opened #5545. |
When readthedocs pip installs a previously installed core component the previous version doesn't get fully uninstalled. This is caused by the
--ignore-installed
flag and the results can be disastrous: https://stackoverflow.com/a/51916623