Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serve custom 404 pages from Django #5644

Merged
merged 2 commits into from
May 9, 2019
Merged

Serve custom 404 pages from Django #5644

merged 2 commits into from
May 9, 2019

Conversation

saadmk11
Copy link
Member

closes #5641

@stsewd stsewd requested a review from humitos April 29, 2019 15:53
@humitos humitos requested a review from a team May 6, 2019 09:02
humitos
humitos approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@humitos humitos merged commit dfe60ed into readthedocs:master May 9, 2019
@saadmk11 saadmk11 deleted the server-custom-404 branch May 9, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serve custom 404 pages from Django
2 participants
@saadmk11 @humitos