You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
clicking the + sign next to the "files changed" sets the url incorrectly (logic is backwards).
When you first load the html file, the "+" sign is visible and the files changed are hidden.
but when you click it, it sets the URL to diff.html#d2h-hide-2t9. Clicking the (now changed to) minus sign, sets the URL to diff.html#d2h-show-w29. so, this seems backwards. clicking show should set the URL to a "show" status, and visa versa.
while we're on this topic..is it possible for you to change the +/- sign to something more obvious, like "show/hide", or "show files/hide files"?
i ask because the + sign is rather obscure and i'm using this for people who aren't as tech savvy, so a tiny '+' sign would probably largely go unnoticed.
The text was updated successfully, but these errors were encountered:
hey, well it sounds good, (and the other issues that you worked on), but i tried using diff2html-cli 1.4.2 on windows, and it generates a page where instead of the +/- button, it shows hide.
which is great, but it's no longer a link. it's blue, but unable to click. so this actually breaks that feature (no way to expand the files changed summary)
clicking the + sign next to the "files changed" sets the url incorrectly (logic is backwards).
When you first load the html file, the "+" sign is visible and the files changed are hidden.
but when you click it, it sets the URL to diff.html#d2h-hide-2t9. Clicking the (now changed to) minus sign, sets the URL to diff.html#d2h-show-w29. so, this seems backwards. clicking show should set the URL to a "show" status, and visa versa.
while we're on this topic..is it possible for you to change the +/- sign to something more obvious, like "show/hide", or "show files/hide files"?
i ask because the + sign is rather obscure and i'm using this for people who aren't as tech savvy, so a tiny '+' sign would probably largely go unnoticed.
The text was updated successfully, but these errors were encountered: