Fix file summary switch #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2016
| } | ||
|
|
||
| Diff2HtmlUI.prototype.draw = function(targetId, config) { | ||
| var that = this; |
There was a problem hiding this comment.
I don't think var that = this; is necessary here because there are no scope changes in the method.
|
Looks good. If everything can be accomplish without jQuery maybe is not worth it to include it, but I don't see any harm to include it using a CDN. |
rtfpessoa
force-pushed
the
fix-file-summary-switch
branch
2 times, most recently
from
9309400
to
e656e93
Compare
Introduce diff2html-ui to perform any ui anymations or dynamic changes like hightlight or animations.
rtfpessoa
force-pushed
the
fix-file-summary-switch
branch
from
e656e93
to
43666f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55
To perform this fix I decided to start diff2html-ui js module to simplify the html dynamic changes highlight or animations.
This is still a very simple idea and the code is very basic.
Not sure if I should use jQuery for this or just plain js like I did. Any suggestions?