Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

can not disable generateSitemap and generateRobotstxt #20

Closed
luglio7 opened this issue Nov 28, 2013 · 8 comments
Closed

can not disable generateSitemap and generateRobotstxt #20

luglio7 opened this issue Nov 28, 2013 · 8 comments

Comments

@luglio7
Copy link

luglio7 commented Nov 28, 2013

this code does not disable sitemap and robots generations

swig : {
            build : {
                src  : 'swig/*.swig',
                dest : 'html/',
                generateSitemap : false,
                generateRobotstxt : false
            }
        },
@luglio7
Copy link
Author

luglio7 commented Nov 28, 2013

found the bug

generateSitemap = config.data.generateSitemap || true,
generateRobotstxt = config.data.generateRobotstxt || true,

these vars will alway be true because false || true will always return true

@nickpack
Copy link
Collaborator

@luglio7 Good spot, I'll get that fixed.

MrFranke added a commit to MrFranke/grunt-swig that referenced this issue Dec 20, 2013
@MrFranke MrFranke mentioned this issue Dec 20, 2013
rtgibbons added a commit that referenced this issue Dec 20, 2013
@zdwolfe
Copy link

zdwolfe commented Jan 14, 2014

closed?

@zdwolfe
Copy link

zdwolfe commented Aug 8, 2014

Still an issue in 0.2.1. Going to fix?

@rtgibbons
Copy link
Owner

Sad truth is I don't use the plugin anymore; and no one has stepped up to commit any changes that it needs on a consistent basis to get the plugin updated.

If you want to dive in and fix this and some other bugs I'd gladly give you push permissions

@colthreepv
Copy link

I agree with @rtgibbons and hope we find some contributors, you could write on the README file that you're looking for maintainers.

I think this project is worth the time it requires, haven't found anything else so minimalistic and effective.
Maybe i'll compile some more detailed PR so you can blindly push accept and forget about it :)

@zdwolfe
Copy link

zdwolfe commented Aug 26, 2014

I still use this frequently - would you consider passing the torch?

@rtgibbons
Copy link
Owner

Definitely, I've updated the Readme with a Call for Help. I believe @kengoldfarb might be interested also.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants