Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Add template basename to template variables #14

Closed
wants to merge 4 commits into from

Conversation

polem
Copy link
Contributor

@polem polem commented Jun 21, 2013

Usage example :

<ul class="nav">
  <li {% if basename == 'index' %} class="active"{% endif %}><a href="/">Home</a></li>
  <li {% if basename == 'page1' %} class="active"{% endif %}><a href="page1.html">Page 1</a></li>
  <li {% if basename == 'page2' %} class="active"{% endif %}><a href="page2.html">Page 2</a></li>
</ul>

@nickpack
Copy link
Collaborator

Thats a great idea, thanks! I'll get it merged and released tonight.

@rtgibbons
Copy link
Owner

This is great; If you can go ahead and add some test around this; then we can get it merged in.

@polem
Copy link
Contributor Author

polem commented Sep 17, 2013

is it ok for you ?

@rtgibbons
Copy link
Owner

Instead of overriding the old test, you should create new fixtures and test.

@polem
Copy link
Contributor Author

polem commented Sep 18, 2013

Done !

@rtgibbons
Copy link
Owner

Thanks, I'm in the process of packing up and moving through the rest of the week, so I'm pretty swamped. I'll review all of this when I get back online next week. @nickpack if it all looks good to you; feel free to merge.

@nickpack
Copy link
Collaborator

Sorry guys, been a bit under it this week - I'll try and get to it at the weekend.

@nickpack
Copy link
Collaborator

@polem All merged, I didn't use your PR as I squashed all of your commits into one. Version 0.1.1 has your changes included and should be making its way to npm very shortly :)

@nickpack nickpack closed this Sep 23, 2013
@nickpack
Copy link
Collaborator

4a7271c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants