API Set parameters with the builder pattern #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the API to enable setting parameters with the builder pattern, e.g.
which in this case is equivalent to
VTextTokenizer::default()
.Vectorizers can similarly be intialized with,
with the default implementations with e.g.
CountVectorizer::<VTextTokenizer>::default()
. The API may still change somewhat in this latter part.Model parameters are now consistently stored as,
I have not used
derive_builder
so far, so this does add some boilerplate in the code.