-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in DRC detection #307
Comments
@RTimothyEdwards
|
The only thing I changed in 8.3.471 is the parsing of arguments to the "select" command. My best guess is that in fixing the parsing of some of the "select" syntax that was broken, I broke something else. Is there a critical "select" command in the DRC script? |
If I run the script commands individually, then the issue is clearly with the "select" command since "select top cell" returns "PHY_EDGE_ROW_1_Left_14" and not "inverter". Not sure why yet---I ran other quick tests and "select top cell" appeared to be doing the right thing. |
The problem seems to be specific to using "magic -dnull". |
Version 8.3.482 should fix this. The "select top cell" was behaving like "select cell" because there was no specific code handling the "top" option. The change to be more systematic about handling the various arguments like "more", "less", etc., caused this issue to suddenly manifest itself. The new code simply registers the fact that "top" has been issued and selects the top level cell as it should. I have tested this on the reproducible case and it works. |
Confirmed fixed. Thanks, Tim! |
Magic version
8.3.466
correctly finds DRC issues in a gds file, but8.3.479
reports no DRC errors. Are we missing something…?reproducible.tgz
The text was updated successfully, but these errors were encountered: