This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
also call provides/invalidates in error cases #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2859119:
|
phryneas
commented
Mar 20, 2021
Comment on lines
+27
to
31
| type GetResultDescriptionFn<EntityTypes extends string, ResultType, QueryArg, ErrorType> = ( | ||
| result: ResultType | undefined, | ||
| error: ErrorType | undefined, | ||
| arg: QueryArg | ||
| ) => ReadonlyArray<EntityDescription<EntityTypes>>; |
There was a problem hiding this comment.
Up for discussion: instead of going (result, arg) => Entities to (result?, error?, arg) => Entities, we could also go for
(arg, result?, error?) => Entities
or
({result, error, arg}) => Entities
There was a problem hiding this comment.
i think having the original input last makes sense so it follows the whole acc, curr, array type of signature?
size-limit report 📦
|
|
Mergged in #201 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adresses #170.
It is at the moment of writing a breaking change as it changes the signature of invalidates/provides from
(result, args) => Entitiesto(result?, error?, args) => Entities.It only triggers on handled errors, which means a simple
throwin thebaseQuerywould pass by this, only an error returned by returning{ error: ... }frombaseQuerywould lead to this.