mergesort(in python) #77
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @abhirai7 - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Incorrect variable used for initializing 'k'. (link)
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue, 2 other issues
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| left = [0] * (n1) | ||
| R = [0] * (n2) |
There was a problem hiding this comment.
issue (code_clarification): Variable shadowing may lead to confusion.
The variable 'left' is used both as a parameter to the merge function and as a local variable within it. Consider renaming the local variable to avoid confusion and potential bugs.
|
|
||
| i = 0 | ||
| j = 0 | ||
| k = left |
There was a problem hiding this comment.
issue (bug_risk): Incorrect variable used for initializing 'k'.
The variable 'k' is intended to be an index for the main array 'arr' but is mistakenly initialized with 'left', which is now a list. This should be initialized with the 'left' parameter's value instead.
| arr = [1, 54, 343, 523] | ||
| merge_sort(arr, 0, len(arr) - 1) | ||
|
|
||
| print(arr) |
There was a problem hiding this comment.
suggestion (code_refinement): Consider removing or commenting out debug prints before finalizing.
While useful during development, direct print statements like this can clutter output in production or when the code is used as part of a larger application.
No description provided.