Fixed minor coffeescript test failures. #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| context "disabling coffee-script wrapper globally" do | ||
| setup do | ||
| @bare = Tilt::CoffeeScriptTemplate.default_bare | ||
| Tilt::CoffeeScriptTemplate.default_bare = true |
There was a problem hiding this comment.
Hmm. Strange. @josh Does this look right to you? Not sure how we missed that for so long.
There was a problem hiding this comment.
I've stared at this ~20 minutes and I guess it's true.
rtomayko
added a commit
that referenced
this pull request
Jan 9, 2012
Fixed minor coffeescript test failures.
|
In coffee-script 1.2.0, the closure may not be generated if there are no global variables. So a simple case of |
|
Thanks. |
|
+1 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
the coffeescript-tests seemed to fail for small things.
Could somebody please have a look at the "disabling coffee-script wrapper globally"-section?
As I read it, it was not disabling the wrapper globally.
Thanks