Support 'sassc' gem #336
Support 'sassc' gem #336
Conversation
|
I tried this branch with our application and all specs pass and Edit: Although I just realised I have sass in Gemfile because we are on sprockets 3 which fails without sass. Edit: I tried spockets 4.x (by pinning to master, since it isn't released yet) and I get some sprockets errors, not related to tilt, a missing manifest.js file. I'll take a look at this tomorrow and see if I can get it working. But the PR looks good regardless. |
| rescue LoadError => err | ||
| begin | ||
| require 'sass' | ||
| Sass == ::Sass |
There was a problem hiding this comment.
Hah! There's actually a typo here (==), but it turns out to not really matter due to the constant lookup rules.
There was a problem hiding this comment.
Great spot. I'm surprised it actually works!
|
Looking forward to when this is merged. I tried to replace sass with sassc on a sinatra project, and came to realize that tilt doesn't have support for sassc yet. For the moment, I'm using this gem which pretty much does exactly the same as this PR: https://github.com/anirbanmu/tilt-sassc |
|
Agreed. Looks solid 👍 |
|
This has now been merged! |
|
@judofyr thanks! Can you, if possible, leave a comment on here when you push 2.0.9 to rubygems? Otherwise I'll keep an eye out for it on rubygems. |
|
2.0.9 has been pushed! |
This fixes #334 and is an alternative to #335
/cc @jdickey @krisleech @tdreyno