Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate dependency on deprecated 'sass' Gem #334

Closed
jdickey opened this issue Oct 10, 2018 · 6 comments
Closed

Eliminate dependency on deprecated 'sass' Gem #334

jdickey opened this issue Oct 10, 2018 · 6 comments

Comments

@jdickey
Copy link

jdickey commented Oct 10, 2018

When doing a bundle install of any app requiring the sass Gem, one gets the following message after completion:

Post-install message from sass:

Ruby Sass is deprecated and will be unmaintained as of 26 March 2019.

* If you use Sass as a command-line tool, we recommend using Dart Sass, the new
  primary implementation: https://sass-lang.com/install

* If you use Sass as a plug-in for a Ruby web framework, we recommend using the
  sassc gem: https://github.com/sass/sassc-ruby#readme

* For more details, please refer to the Sass blog:
  http://sass.logdown.com/posts/7081811

A cursory inspection suggests that the only changes necessary for Tilt to support sassc 2.0.0 would be to change lib/tilt/sass.rb to require 'sassc' rather than 'sass' and to change the #prepare method to instantiate ::SassC::Engine rather than the current ::Sass::Engine.

@jdickey jdickey changed the title Eliminate dependency on 'sass' Gem Eliminate dependency on deprecated 'sass' Gem Oct 11, 2018
jdickey added a commit to jdickey/tilt that referenced this issue Oct 11, 2018
@krisleech
Copy link

I can confirm this branch fixes an issue with the haml gem where inline sass fails with "scss" filter's sass dependency missing: try installing it or adding it to your Gemfile.

gem 'tilt', git: 'https://github.com/jdickey/tilt.git', branch: 'hotfix/334-replace-sass-with-sassc'

@tdreyno
Copy link

tdreyno commented Nov 9, 2018

Waiting on this for middleman/middleman too

@judofyr
Copy link
Collaborator

judofyr commented Nov 13, 2018

I hear you. I stumbled upon this myself. Let me see if I can have a look at it this week.

@judofyr
Copy link
Collaborator

judofyr commented Nov 28, 2018

Build for 2.0.9 running now: https://travis-ci.com/judofyr/tilt/builds/92808753 (Not sure why, but the rtomayko Travis CI repo isn't running)

@zbynek
Copy link

zbynek commented Jul 12, 2019

I guess this issue can be closed (FTR fixed in 9feb916 , 4566c58)

@jdickey
Copy link
Author

jdickey commented Jul 25, 2019

Closing; appears fixed in 2.0.9. Thanks, @judofyr and all. Sorry for the atypically slow response; I’ve spent the last month in and out of hospital. Health improved; bank balance, less so. 😩

@jdickey jdickey closed this as completed Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants