Fixed a dumb logic error with the concurrent_insert check

rtucker · Aug 13, 2007 · efc984f · efc984f
1 parent 04e84a7
commit efc984f
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/mysqltuner.pl b/mysqltuner.pl
@@ -505,12 +505,10 @@ sub mysql_stats {
     # Performance options
     if ($mysqlvermajor == 3 || ($mysqlvermajor == 4 && $mysqlverminor == 0)) {
         push(@generalrec,"Upgrade to MySQL 4.1+ to use concurrent MyISAM inserts");
-    } elsif ($myvar{'concurrent_insert'} eq "OFF" || $myvar{'concurrent_insert'} < 1) {
-        if ($mysqlvermajor == 4) {
-            push(@generalrec,"Enable concurrent_insert by setting it to 'ON'");
-        } else {
-            push(@generalrec,"Enable concurrent_insert by setting it to 1");
-        }
+    } elsif ($myvar{'concurrent_insert'} eq "OFF") {
+        push(@generalrec,"Enable concurrent_insert by setting it to 'ON'");
+    } elsif ($myvar{'concurrent_insert'} eq 0) {
+        push(@generalrec,"Enable concurrent_insert by setting it to 1");
     }
 }