Skip to content

Commit

Permalink
Remove silly warnings about nothing
Browse files Browse the repository at this point in the history
  • Loading branch information
@bclothier
bclothier committed May 15, 2018
1 parent 86c31c9 commit 034d632
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 32 deletions.
15 changes: 10 additions & 5 deletions RubberduckCodeAnalysis/ComVisibleTypeAnalyzer.cs
View file
Expand Up @@ -10,8 +10,9 @@ namespace RubberduckCodeAnalysis
[DiagnosticAnalyzer(LanguageNames.CSharp)]
public class ComVisibleTypeAnalyzer : DiagnosticAnalyzer
{
private const string MissingGuidId = "MissingGuidId";
private static readonly DiagnosticDescriptor MissingGuidRule = new DiagnosticDescriptor(
new LocalizableResourceString(nameof(Resources.MissingGuidId), Resources.ResourceManager, typeof(Resources)).ToString(),
MissingGuidId,
new LocalizableResourceString(nameof(Resources.MissingGuidTitle), Resources.ResourceManager, typeof(Resources)),
new LocalizableResourceString(nameof(Resources.MissingGuidMessageFormat), Resources.ResourceManager, typeof(Resources)),
new LocalizableResourceString(nameof(Resources.AnalyzerCategory), Resources.ResourceManager, typeof(Resources)).ToString(),
Expand All @@ -20,8 +21,9 @@ public class ComVisibleTypeAnalyzer : DiagnosticAnalyzer
new LocalizableResourceString(nameof(Resources.MissingGuidDescription), Resources.ResourceManager, typeof(Resources))
);

private const string MissingClassInterfaceId = "MissingClassInterface";
private static readonly DiagnosticDescriptor MissingClassInterfaceRule = new DiagnosticDescriptor(
new LocalizableResourceString(nameof(Resources.MissingClassInterfaceId), Resources.ResourceManager, typeof(Resources)).ToString(),
MissingClassInterfaceId,
new LocalizableResourceString(nameof(Resources.MissingClassInterfaceTitle), Resources.ResourceManager, typeof(Resources)),
new LocalizableResourceString(nameof(Resources.MissingClassInterfaceMessageFormat), Resources.ResourceManager, typeof(Resources)),
new LocalizableResourceString(nameof(Resources.AnalyzerCategory), Resources.ResourceManager, typeof(Resources)).ToString(),
Expand All @@ -30,8 +32,9 @@ public class ComVisibleTypeAnalyzer : DiagnosticAnalyzer
new LocalizableResourceString(nameof(Resources.MissingClassInterfaceDescription), Resources.ResourceManager, typeof(Resources))
);

private const string MissingProgIdId = "MissingProgId";
private static readonly DiagnosticDescriptor MissingProgIdRule = new DiagnosticDescriptor(
new LocalizableResourceString(nameof(Resources.MissingProgIdId), Resources.ResourceManager, typeof(Resources)).ToString(),
MissingProgIdId,
new LocalizableResourceString(nameof(Resources.MissingProgIdTitle), Resources.ResourceManager, typeof(Resources)),
new LocalizableResourceString(nameof(Resources.MissingProgIdMessageFormat), Resources.ResourceManager, typeof(Resources)),
new LocalizableResourceString(nameof(Resources.AnalyzerCategory), Resources.ResourceManager, typeof(Resources)).ToString(),
Expand All @@ -40,8 +43,9 @@ public class ComVisibleTypeAnalyzer : DiagnosticAnalyzer
new LocalizableResourceString(nameof(Resources.MissingProgIdDescription), Resources.ResourceManager, typeof(Resources))
);

private const string MissingComDefaultInterfaceId = "MissingComDefaultInterface";
private static readonly DiagnosticDescriptor MissingComDefaultInterfaceRule = new DiagnosticDescriptor(
new LocalizableResourceString(nameof(Resources.MissingComDefaultInterfaceId), Resources.ResourceManager, typeof(Resources)).ToString(),
MissingComDefaultInterfaceId,
new LocalizableResourceString(nameof(Resources.MissingComDefaultInterfaceTitle), Resources.ResourceManager, typeof(Resources)),
new LocalizableResourceString(nameof(Resources.MissingComDefaultInterfaceMessageFormat), Resources.ResourceManager, typeof(Resources)),
new LocalizableResourceString(nameof(Resources.AnalyzerCategory), Resources.ResourceManager, typeof(Resources)).ToString(),
Expand All @@ -50,8 +54,9 @@ public class ComVisibleTypeAnalyzer : DiagnosticAnalyzer
new LocalizableResourceString(nameof(Resources.MissingComDefaultInterfaceDescription), Resources.ResourceManager, typeof(Resources))
);

private const string MissingInterfaceTypeId = "MissingInterfaceType";
private static readonly DiagnosticDescriptor MissingInterfaceTypeRule = new DiagnosticDescriptor(
new LocalizableResourceString(nameof(Resources.MissingInterfaceTypeId), Resources.ResourceManager, typeof(Resources)).ToString(),
MissingInterfaceTypeId,
new LocalizableResourceString(nameof(Resources.MissingInterfaceTypeTitle), Resources.ResourceManager, typeof(Resources)),
new LocalizableResourceString(nameof(Resources.MissingInterfaceTypeMessageFormat), Resources.ResourceManager, typeof(Resources)),
new LocalizableResourceString(nameof(Resources.AnalyzerCategory), Resources.ResourceManager, typeof(Resources)).ToString(),
Expand Down
36 changes: 18 additions & 18 deletions RubberduckCodeAnalysis/RubberduckCodeAnalysis.csproj
View file
Expand Up @@ -32,34 +32,34 @@
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<ItemGroup>
<Reference Include="Microsoft.CodeAnalysis, Version=2.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.Common.2.8.0\lib\netstandard1.3\Microsoft.CodeAnalysis.dll</HintPath>
<Reference Include="Microsoft.CodeAnalysis, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.Common.1.0.1\lib\net45\Microsoft.CodeAnalysis.dll</HintPath>
</Reference>
<Reference Include="Microsoft.CodeAnalysis.CSharp, Version=2.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.CSharp.2.8.0\lib\netstandard1.3\Microsoft.CodeAnalysis.CSharp.dll</HintPath>
<Reference Include="Microsoft.CodeAnalysis.CSharp, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.CSharp.1.0.1\lib\net45\Microsoft.CodeAnalysis.CSharp.dll</HintPath>
</Reference>
<Reference Include="Microsoft.CodeAnalysis.CSharp.Workspaces, Version=2.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.CSharp.Workspaces.2.8.0\lib\netstandard1.3\Microsoft.CodeAnalysis.CSharp.Workspaces.dll</HintPath>
<Reference Include="Microsoft.CodeAnalysis.CSharp.Workspaces, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.CSharp.Workspaces.1.0.1\lib\net45\Microsoft.CodeAnalysis.CSharp.Workspaces.dll</HintPath>
</Reference>
<Reference Include="Microsoft.CodeAnalysis.VisualBasic, Version=2.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.VisualBasic.2.8.0\lib\netstandard1.3\Microsoft.CodeAnalysis.VisualBasic.dll</HintPath>
<Reference Include="Microsoft.CodeAnalysis.VisualBasic, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.VisualBasic.1.0.1\lib\net45\Microsoft.CodeAnalysis.VisualBasic.dll</HintPath>
</Reference>
<Reference Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces, Version=2.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.VisualBasic.Workspaces.2.8.0\lib\netstandard1.3\Microsoft.CodeAnalysis.VisualBasic.Workspaces.dll</HintPath>
<Reference Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.VisualBasic.Workspaces.1.0.1\lib\net45\Microsoft.CodeAnalysis.VisualBasic.Workspaces.dll</HintPath>
</Reference>
<Reference Include="Microsoft.CodeAnalysis.Workspaces, Version=2.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.Workspaces.Common.2.8.0\lib\net46\Microsoft.CodeAnalysis.Workspaces.dll</HintPath>
<Reference Include="Microsoft.CodeAnalysis.Workspaces, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.Workspaces.Common.1.0.1\lib\net452\Microsoft.CodeAnalysis.Workspaces.dll</HintPath>
</Reference>
<Reference Include="Microsoft.CodeAnalysis.Workspaces.Desktop, Version=2.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.Workspaces.Common.2.8.0\lib\net46\Microsoft.CodeAnalysis.Workspaces.Desktop.dll</HintPath>
<Reference Include="Microsoft.CodeAnalysis.Workspaces.Desktop, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.CodeAnalysis.Workspaces.Common.1.0.1\lib\net452\Microsoft.CodeAnalysis.Workspaces.Desktop.dll</HintPath>
</Reference>
<Reference Include="System" />
<Reference Include="System.AppContext, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.AppContext.4.3.0\lib\net46\System.AppContext.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System.Collections.Immutable, Version=1.2.2.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.Collections.Immutable.1.4.0\lib\portable-net45+win8+wp8+wpa81\System.Collections.Immutable.dll</HintPath>
<Reference Include="System.Collections.Immutable, Version=1.1.36.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.Collections.Immutable.1.1.36\lib\portable-net45+win8+wp8+wpa81\System.Collections.Immutable.dll</HintPath>
</Reference>
<Reference Include="System.ComponentModel.Composition" />
<Reference Include="System.Composition.AttributedModel, Version=1.0.32.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
Expand Down Expand Up @@ -98,8 +98,8 @@
<HintPath>..\packages\System.IO.FileSystem.Primitives.4.3.0\lib\net46\System.IO.FileSystem.Primitives.dll</HintPath>
</Reference>
<Reference Include="System.Numerics" />
<Reference Include="System.Reflection.Metadata, Version=1.4.2.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.Reflection.Metadata.1.5.0\lib\portable-net45+win8\System.Reflection.Metadata.dll</HintPath>
<Reference Include="System.Reflection.Metadata, Version=1.0.21.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.Reflection.Metadata.1.0.21\lib\portable-net45+win8\System.Reflection.Metadata.dll</HintPath>
</Reference>
<Reference Include="System.Security.Cryptography.Algorithms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.Security.Cryptography.Algorithms.4.3.1\lib\net46\System.Security.Cryptography.Algorithms.dll</HintPath>
Expand Down
18 changes: 9 additions & 9 deletions RubberduckCodeAnalysis/packages.config
View file
@@ -1,18 +1,18 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Microsoft.CodeAnalysis" version="2.8.0" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis" version="1.0.1" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.Analyzers" version="2.6.0" targetFramework="net46" developmentDependency="true" />
<package id="Microsoft.CodeAnalysis.Common" version="2.8.0" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.CSharp" version="2.8.0" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.CSharp.Workspaces" version="2.8.0" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.VisualBasic" version="2.8.0" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.VisualBasic.Workspaces" version="2.8.0" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.Workspaces.Common" version="2.8.0" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.Common" version="1.0.1" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.CSharp" version="1.0.1" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.CSharp.Workspaces" version="1.0.1" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.VisualBasic" version="1.0.1" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.VisualBasic.Workspaces" version="1.0.1" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.Workspaces.Common" version="1.0.1" targetFramework="net46" />
<package id="Microsoft.Composition" version="1.0.31" targetFramework="net46" />
<package id="System.AppContext" version="4.3.0" targetFramework="net46" />
<package id="System.Collections" version="4.3.0" targetFramework="net46" />
<package id="System.Collections.Concurrent" version="4.3.0" targetFramework="net46" />
<package id="System.Collections.Immutable" version="1.4.0" targetFramework="net46" />
<package id="System.Collections.Immutable" version="1.1.36" targetFramework="net46" />
<package id="System.Composition" version="1.1.0" targetFramework="net46" />
<package id="System.Composition.AttributedModel" version="1.1.0" targetFramework="net46" />
<package id="System.Composition.Convention" version="1.1.0" targetFramework="net46" />
Expand All @@ -33,7 +33,7 @@
<package id="System.Linq" version="4.3.0" targetFramework="net46" />
<package id="System.Linq.Expressions" version="4.3.0" targetFramework="net46" />
<package id="System.Reflection" version="4.3.0" targetFramework="net46" />
<package id="System.Reflection.Metadata" version="1.5.0" targetFramework="net46" />
<package id="System.Reflection.Metadata" version="1.0.21" targetFramework="net46" />
<package id="System.Resources.ResourceManager" version="4.3.0" targetFramework="net46" />
<package id="System.Runtime" version="4.3.0" targetFramework="net46" />
<package id="System.Runtime.Extensions" version="4.3.0" targetFramework="net46" />
Expand Down

0 comments on commit 034d632

Please sign in to comment.