Do not report variable not used if it has assignments. Closes #2427

rubberduck-vba · Oct 28, 2018 · 36737a4 · 36737a4
1 parent 7ae665a
commit 36737a4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/Rubberduck.CodeAnalysis/Inspections/Concrete/VariableNotUsedInspection.cs b/Rubberduck.CodeAnalysis/Inspections/Concrete/VariableNotUsedInspection.cs
@@ -22,7 +22,7 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
                 .Where(declaration =>
                     !declaration.IsWithEvents
                     && !IsIgnoringInspectionResultFor(declaration, AnnotationName)
-                    && declaration.References.All(reference => reference.IsAssignment));
+                    && !declaration.References.Any());
 
             return declarations.Select(issue => 
                 new DeclarationInspectionResult(this,

diff --git a/RubberduckTests/Inspections/VariableNotUsedInspectionTests.cs b/RubberduckTests/Inspections/VariableNotUsedInspectionTests.cs
@@ -148,12 +148,24 @@ public void VariableNotUsed_DoesNotReturnsResult_UsedInNameStatement()
 
         [Test]
         [Category("Inspections")]
-        public void InspectionName()
+        public void VariableUsed_DoesNotReturnResultIfAssigned()
         {
-            const string inspectionName = "VariableNotUsedInspection";
-            var inspection = new VariableNotUsedInspection(null);
+            const string inputCode =
+                @"Function Foo() As Boolean
+    Dim var1 as String
+    var1 = ""test""
+End Function";
+
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+
+                var inspection = new VariableNotUsedInspection(state);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
 
-            Assert.AreEqual(inspectionName, inspection.Name);
+                Assert.AreEqual(0, inspectionResults.Count());
+            }
         }
+
     }
 }