Add comments to explicitly remind of the required encoding for all is…

…s files.
rubberduck-vba · Apr 20, 2018 · 4568b9d · 4568b9d
1 parent 4bfde8a
commit 4568b9d
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/Rubberduck.Deployment/BuildRegistryScript.ps1 b/Rubberduck.Deployment/BuildRegistryScript.ps1
@@ -76,7 +76,8 @@ try
 
 		$writer = New-Object Rubberduck.Deployment.Writers.InnoSetupRegistryWriter;
 		$content = $writer.Write($entries);
-
+
+		# The file must be encoded in UTF-8 BOM
 		$regFile = ($includeDir + ($file -replace ".dll", ".reg.iss"));
 		$encoding = New-Object System.Text.UTF8Encoding $true;
 		[System.IO.File]::WriteAllLines($regFile, $content, $encoding);

diff --git a/Rubberduck.Deployment/InnoSetup/Includes/English.CustomMessages.iss b/Rubberduck.Deployment/InnoSetup/Includes/English.CustomMessages.iss
@@ -1,4 +1,4 @@
-; English Custom Messages Include
+; English Custom Messages Include -- Must be encoded in UTF-8 BOM
 English.PerUser=Current User
 English.Everyone=All Users
 English.RegisterAddin=Repair VBE Addin registration

diff --git a/Rubberduck.Deployment/InnoSetup/Includes/French.CustomMessages.iss b/Rubberduck.Deployment/InnoSetup/Includes/French.CustomMessages.iss
@@ -1,4 +1,4 @@
-; French Custom Messages Include
+; French Custom Messages Include -- Must be encoded in UTF-8 BOM
 French.PerUser=Utilisateur courant
 French.Everyone=Tous les utilisateurs
 French.RegisterAddin=Réparer l'enregistrement du complément VBE

diff --git a/Rubberduck.Deployment/InnoSetup/Includes/German.CustomMessages.iss b/Rubberduck.Deployment/InnoSetup/Includes/German.CustomMessages.iss
@@ -1,4 +1,4 @@
-; German Custom Messages Include
+; German Custom Messages Include -- Must be encoded in UTF-8 BOM
 German.PerUser=Aktueller Benutzer
 German.Everyone=Alle Benutzer
 German.RegisterAddin=VBE AddIn Registrierung reparieren

diff --git a/Rubberduck.Deployment/InnoSetup/Installer Build Script.iss b/Rubberduck.Deployment/InnoSetup/Installer Build Script.iss
@@ -1,4 +1,6 @@
-#pragma include __INCLUDE__ + ";" + SourcePath + "\Includes\"
+;The file must be encoded in UTF-8 BOM
+
+#pragma include __INCLUDE__ + ";" + SourcePath + "\Includes\"
 
 #define protected
 #ifndef Config