Merge pull request #6032 from tommy9/SequenceEqualsTests#5827

Sequence equals tests#5827
rubberduck-vba · Oct 17, 2022 · 9168dbf · 9168dbf
2 parents c78459a + ad4886f
commit 9168dbf
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/Rubberduck.Main/ComClientLibrary/UnitTesting/AssertClass.cs b/Rubberduck.Main/ComClientLibrary/UnitTesting/AssertClass.cs
@@ -272,6 +272,7 @@ protected void TestArraySequenceEquity(Array expected, Array actual, string mess
                     return;
                 }
                 AssertHandler.OnAssertSucceeded();
+                return;
             }
 
             for (var rank = 0; rank < expected.Rank; rank++)
@@ -287,6 +288,7 @@ protected void TestArraySequenceEquity(Array expected, Array actual, string mess
                         return;
                     }
                     AssertHandler.OnAssertSucceeded();
+                    return;
                 }
 
                 expectedBound = expected.GetUpperBound(rank);
@@ -300,6 +302,7 @@ protected void TestArraySequenceEquity(Array expected, Array actual, string mess
                         return;
                     }
                     AssertHandler.OnAssertSucceeded();
+                    return;
                 }
             }
 

diff --git a/RubberduckTests/UnitTesting/AssertTests.cs b/RubberduckTests/UnitTesting/AssertTests.cs
@@ -345,6 +345,40 @@ public void OnAssertInconclusive_ReturnsResultInconclusive()
             Assert.AreEqual(TestOutcome.Inconclusive, _args.Outcome);
         }
 
+        [Category("Unit Testing")]
+        [Test]
+        public void NotSequenceEqualShouldSucceedWithDifferentRanks()
+        {
+            var assert = new AssertClass();
+
+            int[] lengthsArray2D = new int[2] { 2, 2 };
+            Array myArray2D = Array.CreateInstance(typeof(Int32), lengthsArray2D);
+            int length1Darray = 4;
+            Array myArray1D = Array.CreateInstance(typeof(Int32), length1Darray);
+
+            assert.NotSequenceEquals(myArray2D, myArray1D);
+
+            Assert.AreEqual(TestOutcome.Succeeded, _args.Outcome);
+        }
+
+        [Category("Unit Testing")]
+        [Test]
+        public void NotSequenceEqualShouldSucceedWithDifferentLowerBounds()
+        {
+            var assert = new AssertClass();
+
+            int[] lengthsArray1 = new int[1] { 2 };
+            int[] boundsArray1 = new int[1] { 0 };
+            Array arrayZeroBased = Array.CreateInstance(typeof(Int32),lengthsArray1, boundsArray1);
+            int[] lengthsArray2 = new int[1] { 2 };
+            int[] boundsArray2 = new int[1] { -1 };
+            Array arrayNegative1Based = Array.CreateInstance(typeof(Int32), lengthsArray2, boundsArray2);
+
+            assert.NotSequenceEquals(arrayZeroBased, arrayNegative1Based);
+
+            Assert.AreEqual(TestOutcome.Succeeded, _args.Outcome);
+        }
+
         private static Type GetComObjectType() => Type.GetTypeFromProgID("Scripting.FileSystemObject");
         private object GetComObject() => Activator.CreateInstance(GetComObjectType());
     }