Merge pull request #1 from rubberduck-vba/next

rubberduck-vba · Jun 11, 2015 · 9fe09d5 · 9fe09d5
2 parents 00ce3c9 + 0d967a7
commit 9fe09d5
Show file tree

Hide file tree

Showing 15 changed files with 174 additions and 31 deletions.
diff --git a/RetailCoder.VBE/App.cs b/RetailCoder.VBE/App.cs
@@ -19,12 +19,12 @@ public class App : IDisposable
     {
         private readonly VBE _vbe;
         private readonly AddIn _addIn;
-        private readonly IList<IInspection> _inspections;
-        private readonly Inspector _inspector;
-        private readonly ParserErrorsPresenter _parserErrorsPresenter;
+        private IList<IInspection> _inspections;
+        private Inspector _inspector;
+        private ParserErrorsPresenter _parserErrorsPresenter;
         private readonly IGeneralConfigService _configService = new ConfigurationLoader();
         private readonly ActiveCodePaneEditor _editor;
-        private readonly IRubberduckParser _parser;
+        private IRubberduckParser _parser;
 
         private Configuration _config;
         private RubberduckMenu _menu;
@@ -35,18 +35,12 @@ public App(VBE vbe, AddIn addIn)
         {
             _vbe = vbe;
             _addIn = addIn;
-            _inspections = _configService.GetImplementedCodeInspections();
 
-            _parser = new RubberduckParser();
             _parserErrorsPresenter = new ParserErrorsPresenter(vbe, addIn);
-            _parser.ParseStarted += _parser_ParseStarted;
-            _parser.ParserError += _parser_ParserError;
             _configService.SettingsChanged += _configService_SettingsChanged;
 
             _editor = new ActiveCodePaneEditor(vbe);
 
-            _inspector = new Inspector(_parser, _inspections);
-
             LoadConfig();
         }
 
@@ -71,8 +65,6 @@ private void LoadConfig()
                 _configService.SaveConfiguration(_config);
             }
 
-            EnableCodeInspections(_config);
-
             if (_menu != null)
             {
                 _menu.Dispose();
@@ -92,6 +84,31 @@ private void LoadConfig()
                 _codeInspectionsToolbar.Dispose();
             }
 
+            if (_inspector != null)
+            {
+                _inspector.Dispose();
+            }
+
+            if (_parserErrorsPresenter != null)
+            {
+                _parserErrorsPresenter.Dispose();
+            }
+
+            if (_parser != null)
+            {
+                _parser.ParseStarted -= _parser_ParseStarted;
+                _parser.ParserError -= _parser_ParserError;
+            }
+            _parser = new RubberduckParser();
+            _parser.ParseStarted += _parser_ParseStarted;
+            _parser.ParserError += _parser_ParserError;
+
+            _inspections = _configService.GetImplementedCodeInspections();
+            _inspector = new Inspector(_parser, _inspections);
+            EnableCodeInspections(_config);
+
+            _parserErrorsPresenter = new ParserErrorsPresenter(_vbe, _addIn);
+
             _menu = new RubberduckMenu(_vbe, _addIn, _configService, _parser, _editor, _inspector);
             _menu.Initialize();
 

diff --git a/RetailCoder.VBE/Rubberduck.csproj b/RetailCoder.VBE/Rubberduck.csproj
@@ -1073,10 +1073,12 @@
   </Target>
   <Import Project="..\packages\Antlr4.4.3.0\build\Antlr4.targets" Condition="Exists('..\packages\Antlr4.4.3.0\build\Antlr4.targets')" />
   <PropertyGroup>
-    <PostBuildEvent>c:\Windows\Microsoft.NET\Framework64\v4.0.30319\regasm.exe "$(TargetPath)" /codebase /tlb</PostBuildEvent>
+    <PostBuildEvent>
+    </PostBuildEvent>
   </PropertyGroup>
   <PropertyGroup>
-    <PreBuildEvent>c:\Windows\Microsoft.NET\Framework64\v4.0.30319\regasm.exe "$(TargetPath)" /u</PreBuildEvent>
+    <PreBuildEvent>
+    </PreBuildEvent>
   </PropertyGroup>
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/RetailCoder.VBE/UI/FolderBrowser.cs b/RetailCoder.VBE/UI/FolderBrowser.cs
@@ -27,7 +27,7 @@ public FolderBrowser(string description, bool showNewFolderButton, Environment.S
         }
 
         public FolderBrowser(string description, bool showNewFolderButton)
-            :this(description, showNewFolderButton, Environment.SpecialFolder.MyDocuments)
+            :this(description, showNewFolderButton, Environment.SpecialFolder.MyComputer)
         { }
 
         public FolderBrowser(string description)

diff --git a/RetailCoder.VBE/UI/RubberduckMenu.cs b/RetailCoder.VBE/UI/RubberduckMenu.cs
@@ -217,7 +217,6 @@ protected override void Dispose(bool disposing)
             menuBarControls.Parent.FindControl(_menu.Type, _menu.Id, _menu.Tag, _menu.Visible).Delete();
 
             _disposed = true;
-
             base.Dispose(true);
         }
     }

diff --git a/RetailCoder.VBE/UI/RubberduckUI.Designer.cs b/RetailCoder.VBE/UI/RubberduckUI.Designer.cs
diff --git a/RetailCoder.VBE/UI/RubberduckUI.fr.resx b/RetailCoder.VBE/UI/RubberduckUI.fr.resx
@@ -1049,4 +1049,7 @@ Attention: les valeurs personnalisées seront perdues.</value>
   <data name="SourceControl_MergeFormTitle" xml:space="preserve">
     <value>Fusionner les branches</value>
   </data>
+  <data name="SourceControl_NoRepoFound" xml:space="preserve">
+    <value>z No repository found.</value>
+  </data>
 </root>
diff --git a/RetailCoder.VBE/UI/RubberduckUI.resx b/RetailCoder.VBE/UI/RubberduckUI.resx
@@ -1053,4 +1053,7 @@ Are you sure you want to proceed with this rename?</value>
   <data name="SourceControl_MergeFormTitle" xml:space="preserve">
     <value>Merge branches</value>
   </data>
+  <data name="SourceControl_NoRepoFound" xml:space="preserve">
+    <value>No repository found.</value>
+  </data>
 </root>
diff --git a/RetailCoder.VBE/UI/RubberduckUI.sv.resx b/RetailCoder.VBE/UI/RubberduckUI.sv.resx
@@ -1040,4 +1040,7 @@ Are you sure you want to proceed with this rename?</value>
   <data name="SourceControl_MergeFormTitle" xml:space="preserve">
     <value>z Merge branches</value>
   </data>
+  <data name="SourceControl_NoRepoFound" xml:space="preserve">
+    <value>z No repository found.</value>
+  </data>
 </root>
diff --git a/RetailCoder.VBE/UI/Settings/GeneralSettingsControl.cs b/RetailCoder.VBE/UI/Settings/GeneralSettingsControl.cs
@@ -7,7 +7,8 @@ namespace Rubberduck.UI.Settings
 {
     public partial class GeneralSettingsControl : UserControl
     {
-        private IGeneralConfigService _configService;
+        private readonly IGeneralConfigService _configService;
+        private readonly DisplayLanguageSetting _currentLanguage;
 
         public GeneralSettingsControl()
         {
@@ -36,13 +37,14 @@ private void ResetSettings()
         {
             File.Delete(Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), "Rubberduck\\rubberduck.config"));
             var config = _configService.GetDefaultConfiguration();
-            _configService.SaveConfiguration(config);
+            _configService.SaveConfiguration(config, !Equals(_currentLanguage, config.UserSettings.LanguageSetting));
         }
 
         public GeneralSettingsControl(DisplayLanguageSetting displayLanguage, IGeneralConfigService configService)
             : this()
         {
             _configService = configService;
+            _currentLanguage = displayLanguage;
             LanguageList.SelectedItem = displayLanguage;
         }
 

diff --git a/RetailCoder.VBE/UI/Settings/SettingsDialog.cs b/RetailCoder.VBE/UI/Settings/SettingsDialog.cs
@@ -165,10 +165,12 @@ private void ActivateControl(Control control)
 
         private void SaveConfig()
         {
+            var langChanged = !Equals(_config.UserSettings.LanguageSetting, _generalSettingsView.SelectedLanguage);
+
             _config.UserSettings.LanguageSetting = _generalSettingsView.SelectedLanguage;
             _config.UserSettings.ToDoListSettings.ToDoMarkers = _todoView.TodoMarkers.ToArray();
             // The datagrid view of the CodeInspectionControl seems to keep the config magically in sync, so I don't manually do it here.
-            _configService.SaveConfiguration(_config);
+            _configService.SaveConfiguration(_config, langChanged);
         }
     }
 }
diff --git a/RetailCoder.VBE/UI/SourceControl/BranchesPresenter.cs b/RetailCoder.VBE/UI/SourceControl/BranchesPresenter.cs
@@ -124,6 +124,7 @@ private void HideCreateBranchView()
 
         private void OnShowCreateBranchView(object sender, EventArgs e)
         {
+            if (_view.Local == null) { return; }
             _createView.Show();
         }
 
@@ -141,11 +142,15 @@ private void OnCreateViewCancel(object sender, EventArgs e)
 
         private void OnCreateBranchTextChanged(object sender, EventArgs e)
         {
-            _createView.OkButtonEnabled = !string.IsNullOrEmpty(_createView.UserInputText);
+            _createView.OkButtonEnabled = !string.IsNullOrEmpty(_createView.UserInputText) &&
+                                          !_view.Local.Contains(_createView.UserInputText) &&
+                                          !_createView.UserInputText.Any(char.IsWhiteSpace);
         }
 
         private void OnShowMerge(object sender, EventArgs e)
         {
+            if (_view.Local == null) { return; }
+
             var localBranchNames = _view.Local.ToList();
             _mergeView.SourceSelectorData = localBranchNames;
             _mergeView.DestinationSelectorData = localBranchNames;

diff --git a/RetailCoder.VBE/UI/SourceControl/CreateBranchForm.Designer.cs b/RetailCoder.VBE/UI/SourceControl/CreateBranchForm.Designer.cs
diff --git a/RetailCoder.VBE/UI/SourceControl/SourceControlPresenter.cs b/RetailCoder.VBE/UI/SourceControl/SourceControlPresenter.cs
@@ -91,7 +91,17 @@ private void OnOpenWorkingDirectory(object sender, EventArgs e)
 
                 var project = this.VBE.ActiveVBProject;
                 var repo = new Repository(project.Name, folderPicker.SelectedPath, string.Empty);
-                _provider = _providerFactory.CreateProvider(project, repo);
+
+                try
+                {
+                    _provider = _providerFactory.CreateProvider(project, repo);
+                }
+                catch (SourceControlException)
+                {
+                    MessageBox.Show(RubberduckUI.SourceControl_NoRepoFound, RubberduckUI.SourceControlPanel_Caption,
+                        MessageBoxButtons.OK, MessageBoxIcon.Warning);
+                    return;
+                }
 
                 AddRepoToConfig(repo);
 

diff --git a/RetailCoder.VBE/UI/SourceControl/SourceControlProviderFactory.cs b/RetailCoder.VBE/UI/SourceControl/SourceControlProviderFactory.cs
@@ -23,7 +23,14 @@ public ISourceControlProvider CreateProvider(VBProject project)
 
         public ISourceControlProvider CreateProvider(VBProject project, IRepository repository)
         {
-            return new GitProvider(project, repository);
+            try
+            {
+                return new GitProvider(project, repository);
+            }
+            catch (SourceControlException e)
+            {
+                throw;
+            }
         }
     }
 }