Skip to content

Commit

Permalink
Merge pull request #4459 from retailcoder/next
Browse files Browse the repository at this point in the history
Fix broken .resx reference in Settings dialog / AC settings
  • Loading branch information
retailcoder committed Oct 26, 2018
2 parents 197bce0 + eb52bbd commit e8564b4
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Rubberduck.Core/UI/Settings/AutoCompleteSettings.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
<CheckBox Margin="15,0,15,0"
IsEnabled="{Binding EnableSmartConcat}"
IsChecked="{Binding ConcatVbNewLine}"
Content="{Resx ResxName=Rubberduck.Resources.Settings.AutoCompletesPage, Key=ConcatVbNewline}" />
Content="{Resx ResxName=Rubberduck.Resources.Settings.AutoCompletesPage, Key=ConcatVbNewLine}" />

<Label Margin="10"
Content="{Resx ResxName=Rubberduck.Resources.Settings.AutoCompletesPage, Key=BlockCompletion}"
Expand Down
12 changes: 12 additions & 0 deletions RubberduckTests/AutoComplete/SelfClosingPairCompletionTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,18 @@ public void WhenNextPositionIsClosingChar_ClosingCharMovesSelection()
Assert.AreEqual(expected, result);
}

[Test]
public void WhenNextPositionIsClosingChar_Nested_ClosingCharMovesSelection()
{
var pair = new SelfClosingPair('(', ')');
var input = pair.ClosingChar;
var original = @"foo = MsgBox(""""|)".ToCodeString();
var expected = @"foo = MsgBox("""")|".ToCodeString();

var result = Run(pair, original, input);
Assert.AreEqual(expected, result);
}

[Test]
public void DeletingOpeningCharRemovesPairedClosingChar_Parens()
{
Expand Down

0 comments on commit e8564b4

Please sign in to comment.