Fix unsafe conversion from Char to int

It is not safe to convert from Char to int16, since the unicode code points are unsigned 16-bit integers. The safe conversion it to int32, as also indicated in the docs.
rubberduck-vba · Nov 8, 2023 · f3254a0 · f3254a0
1 parent 32da47c
commit f3254a0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Rubberduck.Parsing/VBA/Extensions/StringExtensions.cs b/Rubberduck.Parsing/VBA/Extensions/StringExtensions.cs
@@ -148,7 +148,7 @@ public static string ToVbExpression(this string managed, bool useConsts = true)
             var literal = string.Empty;
             foreach (var character in managed.ToCharArray())
             {
-                var unicode = Convert.ToInt16(character) > byte.MaxValue;
+                var unicode = Convert.ToInt32(character) > byte.MaxValue;
                 var specialCased = VbCharacterConstants.ContainsKey(character);
                 if (specialCased || char.IsControl(character) && !unicode)
                 {