Procedure can be written as function - RD ver 2.0.8

[peterennis]

Sub is used for Ribbon callbacks.
Ref: https://msdn.microsoft.com/en-us/library/aa942866.aspx?cs-save-lang=1&cs-lang=vb#code-snippet-1
The opportunity recommendation is false in this case.
Also:
Ref: https://social.msdn.microsoft.com/Forums/office/en-US/2c33d20a-b010-4a65-a0c9-762bfd7c0122/ribbon-callback-function?forum=accessdev

[peterennis]

Disable this inspection does not do anything.

[retailcoder]

Disabling an inspection writes to the inspection settings file and sets the selected inspection's severity to do not show - and then it's supposed to refresh the inspection results.

Can you confirm the severity level was not set to do not show? Or is it just a refreshing issue?

[retailcoder]

Ribbon callbacks are a problem, we have no way of knowing that they're callbacks as of yet; they're prime candidates for an @Ignore annotation (which the ignore once quick-fix should insert automatically).

[peterennis]

Settings here:

[peterennis]

"Consider renaming variable" - I could not find a setting and disable the inspection also does nothing.

[peterennis]

@retailcoder - Where do I get details on use of '@ignore ?
Here: #810
It refers to magic comments and what appears to be magic ignore types/variable definitions.

An option to completely @ignore all inspections in a particular module would be useful. Especially where the module is dev/test/poc code.

[ThunderFrame]

I have some proof-of-concept code for pulling the callback names out of Office Open XML documents, and it could probably be made to work with some types of Access CustomUI XML too. It won't be able to handle callbacks in dynamic menus, but that's a bit like asking RD to parse arguments to Application.Run

[retailcoder]

@peterennis @Ignore annotations are introduced by the ignore once quick-fix, and the inspections use them to determine whether to issue an inspection result at a given declaration or identifier reference. They work with the inspection names RD uses internally, which makes them non-trivial to introduce manually. For example using ignore once on a VariableNotUsedInspection inspection result would add an annotation above the variable's declaration:

'@Ignore VariableNotUsed
Dim foo As String

[Vogel612]

Added some relevant Labels. Especially relevant here is the fact that we cannot tell Ribbon Callbacks are just that. As such this is maybe better off as [status-bydesign]. Then again what's not can still be

[retailcoder]

There were two problems here: ProcedureCanBeWrittenAsFunction is a ParseTree inspection that runs directly off each ANTLR IParseTree, as part of the parsing process - these parse tree inspections did not honor the DoNotShow severity level. The other problem was that the inspection didn't honor the @Ignore ProcedureCanBeWrittenAsFunction attribute. Both problems are fixed with #2215.

[retailcoder]

That said, RD still can't tell a Ribbon callback from any other procedure that's not used, and therefore cannot specifically exclude Ribbon callback procedures from its results. This is a known issue though.