Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParserState caching issue? #2528

Closed
retailcoder opened this issue Jan 12, 2017 · 3 comments
Closed

ParserState caching issue? #2528

retailcoder opened this issue Jan 12, 2017 · 3 comments
Labels
bug Identifies work items for known bugs critical Marks a bug as a must-fix, showstopper issue parse-tree-processing
Milestone
Version 2.0.x

Comments

@retailcoder
Copy link
Member

Might be a one-off, but seems identifier references don't consistently get cleaned up:

image

That selection was the location of the other reference to SageContext (With New SageContext) in the first parse, now shifted a number of lines below.
@retailcoder retailcoder added bug Identifies work items for known bugs parse-tree-processing critical Marks a bug as a must-fix, showstopper issue labels Jan 12, 2017
@retailcoder retailcoder added this to the Version 2.0 milestone Jan 12, 2017
@MDoerner
Copy link
Contributor

MDoerner commented Mar 5, 2017

Indeen, we did not clean up references for modules that did not get reparsed (not new and not modified). That has been fixed in PR #2738. Futher cahnges have been made in PR #2764, but should not have reintroduced the problem.

So, if this cannot be reproduced anymore, this issue can be closed.

@MDoerner
Copy link
Contributor

Can this still be reproduced. According to the changes that went into the removal of references, this issue should not exist anymore.

@MDoerner
Copy link
Contributor

Again, does this problem still occur?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Identifies work items for known bugs critical Marks a bug as a must-fix, showstopper issue parse-tree-processing
Projects
None yet
Milestone
Version 2.0.x
Development

No branches or pull requests
2 participants
@retailcoder @MDoerner