Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references of not reparsed components. #2738

Conversation

MDoerner
Copy link
Contributor

Made the ParseCoordinator remove all references upon reparse and not only those to the built-in declarations and the modules that have been modified.

This will have to change again, when I implement selective reference resolving.

This PR will make issue #2737 more obscure since there will never be a DeclarationFinder at whose time of construction any references are are resolved.

…t only those to the built-in declarations and the modules that have been modified.
@MDoerner
Copy link
Contributor Author

MDoerner commented Feb 24, 2017

I made the DeclarationFinder use distinct declarations for the interfaces. This should fix #2737.
However, it could still us a test to verify this does not break again. Well, that is true for everything in the Declataion Finder.

@retailcoder retailcoder merged commit e270a7f into rubberduck-vba:next Feb 25, 2017
This was referenced Mar 5, 2017
@MDoerner MDoerner deleted the ProperlyCleanUpReferencesFromPriorParses branch July 2, 2017 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants