"Ignore Once" annotation line position is affected by previous executions of the quickfix

[daFreeMan]

I have some stubs for future development that are currently not being called. The Procedure {x} is not used inspection is properly identifying that they are not called. The Ignore once Quick Fix does not insert an @Ignore {inspection} annotation.

That's the same picture before & after clicking...

Ignore the 243 meaningful name inspections, please, I know they're there...

[retailcoder]

Just to confirm: "Removed unused declaration" does work, correct?

[daFreeMan]

Yes, "Remove unused declaration" does work.

[Vogel612]

---So I wrote a unit-test for this and it didn't fail--- There is a unit-test that should cover this...https://github.com/rubberduck-vba/Rubberduck/blob/next/RubberduckTests/QuickFixes/IgnoreOnceQuickFixTests.cs#L820

[retailcoder]

@Vogel612 the procedure is first-thing in the module, it does make a difference. Needs tests with Option Explicit and an empty line before the procedure, and then others with two procedures, the first one invoked by the 2nd one, the 2nd one never invoked and triggering the inspection - at least one with and one without empty lines between the two procedures.

[daFreeMan]

According to chat, there's no repo & questions about the version.

Here's the code in question and proof of the version.

DBConfiguration.cls.txt

[retailcoder]

No repro with .2357

[retailcoder]

Wait a minute... just got it!

[retailcoder]

Ok. So the problem seems to be that there's something we're not invalidating on reparse, causing the quickfix to think the annotation should be inserted where it would have been needed before a previous quickfix shifted the module contents down one line. Investigating.

[retailcoder]

There's a work-around though: annotate the procedures bottom-to-top.

[retailcoder]

Reportedly fixed.

[bclothier]

Closing this since this should be fixed in the PR #4693 (and related PRs)